🔒 Fix potential panic on UI button interaction#16
Conversation
In Bevy UI button interaction systems, an unsafe `.unwrap()` and direct array indexing (`children[0]`) was used to access the text components. This could cause panics if a button's layout lacked a single text child entity. This commit updates `sequence_control_button_system`, `curriculum_toggle_system`, `mode_toggle_system`, and `rhythm_mode_toggle_system` to use safe `let-else` destructuring and error handling. Now, interactions gracefully skip without panicking if the child text is missing. Co-authored-by: dynamikdev <717692+dynamikdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed potential panics caused by unwrapping text components from UI button children.
⚠️ Risk: Application crash (Denial of Service) when users click on a UI button (e.g. Sequence Control) if the child text layout unexpectedly changes or fails to spawn.
🛡️ Solution: Replaced
children[0]indexing and.unwrap()with safe destructuring viachildren.first()andtext_query.get_mut(). This ensures we gracefully skip iteration over invalid states instead of crashing the process.PR created automatically by Jules for task 4375027995078623974 started by @dynamikdev